Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(importGlob): warn on default import css #11103

merged 2 commits into from
Nov 28, 2022

fix(importGlob): warn on default import css #11103

merged 2 commits into from
Nov 28, 2022


Copy link

@bluwy bluwy commented Nov 28, 2022


Followup to #11094

I forgot to finish the import glob warnings 馃槄 This should be more accurate now.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Nov 28, 2022
@patak-dev patak-dev merged commit fc0d9e3 into main Nov 28, 2022
@patak-dev patak-dev deleted the fix-glob-warn branch November 28, 2022 21:15
Copy link

I think we shouldn't show a warning for import.meta.glob('./fixture-c/*.css') when the value is not used.
I saw people using this pattern to just import multiple css files.

import.meta.glob('./*.css', { eager: true })

// instead of
import './a.css'
import './b.css'
import './c.css'

Copy link
Member Author

bluwy commented Nov 29, 2022

I've thought about that but that still technically allows them to access the default import in runtime. If import.meta.glob supports "import-only" for side-effects maybe that could allow suppressing the warning 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p3-minor-bug An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants