Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick more v4 bug fixes to v3 #11189

merged 7 commits into from
Dec 5, 2022


Copy link

netlify bot commented Dec 5, 2022

Deploy Preview for vite-docs-v3 ready!

Name Link
🔨 Latest commit 8043ad8
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

/ecosystem-ci run

Copy link

vite-ecosystem-ci bot commented Dec 5, 2022

📝 Ran ecosystem CI: Open

suite result
astro ❌ failure
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ❌ failure
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
sveltekit ❌ failure
vite-plugin-ssr ❌ failure
vite-plugin-react ❌ failure
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ❌ failure
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

Copy link
Member Author

bluwy commented Dec 5, 2022

Besides vite-plugin-vue and vite-plugin-react, looks like sveltekit, vite-plugin-ssr, laravel has issue with the nodejs types. Astro seems to have the same issue in the main branch now (which I'm also looking into) so it's likely not related to the PR.

There's a comment about @types/node in vite-ecosystem-ci. I remember something about not overriding it which could fix this issue 🤔

@patak-dev patak-dev merged commit eba9b42 into v3 Dec 5, 2022
@patak-dev patak-dev deleted the cherry-pick-v3-again branch December 5, 2022 08:33
Copy link

released at 3.2.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

5 participants