Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): resolve dynamic import as esm #11220

merged 1 commit into from
Dec 6, 2022


Copy link

@bluwy bluwy commented Dec 6, 2022


When calling tryNodeResolve when bundling the config, make sure the isRequire option depends on whether the import is a dynamic import or not.

Dynamic imports uses the import exports condition when resolving in Node. So isRequire should be false for that even in vite.config.cjs.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug An edge case that only affects very specific usage (priority) label Dec 6, 2022
Copy link

dominikg commented Dec 6, 2022

this is needed to be able to use esm only plugins from cjs with dynamic import, see tests failing for vite-plugin-svelte 2.0 beta

@patak-dev patak-dev merged commit f8c1ed0 into main Dec 6, 2022
@patak-dev patak-dev deleted the config-require-check branch December 6, 2022 12:54
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p3-minor-bug An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants