New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: wrongly resolve to optimized doppelganger #11290
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think the wrong result is return by this line. It return the optimized bundle without checking whether it is resolveable from the |
I just push a commit to fix it. |
csr632
commented
Dec 10, 2022
bluwy
reviewed
Dec 10, 2022
csr632
commented
Dec 10, 2022
bluwy
reviewed
Dec 11, 2022
bluwy
approved these changes
Dec 12, 2022
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
/ecosystem-ci run nuxt-framework |
📝 Ran ecosystem CI: Open
|
/ecosystem-ci run sveltekit |
/ecosystem-ci run sveltekit |
9 tasks
patak-dev
added a commit
that referenced
this pull request
Dec 18, 2022
This reverts commit 34fec41.
patak-dev
added a commit
that referenced
this pull request
Dec 18, 2022
csr632
added a commit
to csr632/vite
that referenced
this pull request
Dec 18, 2022
csr632
added a commit
to csr632/vite
that referenced
this pull request
Jan 5, 2023
This is reworked in #11410 |
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
futurGH
pushed a commit
to futurGH/vite
that referenced
this pull request
Feb 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feat: deps optimizer
Esbuild Dependencies Optimization
p3-minor-bug 🔨
An edge case that only affects very specific usage (priority)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix a bug:
when a dependency has a doppelganger (duplicate package with same name but different version), and one of it is optimized, then some dependents of the package wrongly get the optimized version(expect unoptimized version).
Example:
When
test-package-a
importtest-package-b
, it expectstest-package-b@2.0.0
. But it actually gettest-package-b@1.0.0
(the optimized bundle).It should resolve to the nested dependency, instead of the optimized doppelganger.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).