Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typecheck create-vite #11295

merged 1 commit into from Dec 15, 2022

chore: typecheck create-vite #11295

merged 1 commit into from Dec 15, 2022


Copy link

@ArnaudBarre ArnaudBarre commented Dec 9, 2022

At the beginning didn't like the red line in my editor for cli.spec.ts.
So I added a ts check.
Then I saw that build.config.ts was not in the config.
Then I got type issues with rollupLicensePlugin.mjs, that I converted to TS
Then I got issue with using import.meta in a cjs project, so I moved it to vite package which is more appropriate IMO and closer to the main importer.
Then I saw that this small project was not strict, which I enabled, but keeping the PR safe so I only added ! assertions and didn't touch runtime behaviour.
Then I saw that src/node/__test__ and scripts were also not covered, so I added them to packages/vite/tsconfig.json

package.json Outdated Show resolved Hide resolved
packages/create-vite/build.config.ts Outdated Show resolved Hide resolved
Copy link

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@patak-dev patak-dev merged commit af86e5b into main Dec 15, 2022
8 of 13 checks passed
@patak-dev patak-dev deleted the typecheck-create-vite branch December 15, 2022 07:08
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants