Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(preview): Revert #10564 - throw Error on missing outDir #11335

merged 1 commit into from
Dec 12, 2022


Copy link

@dominikg dominikg commented Dec 12, 2022

This reverts commit 0a1db8c

configurePreviewServer can be used to make it work regardless of that directory existing, throwing the Error that wasn't there before is a breaking change.

see for details #10564 (comment)


Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

…how 404s due to nonexistent build (vitejs#10564)"

This reverts commit 0a1db8c
@dominikg dominikg mentioned this pull request Dec 12, 2022
9 tasks
@patak-dev patak-dev enabled auto-merge (squash) December 12, 2022 12:12
@patak-dev patak-dev merged commit 3aaa0ea into vitejs:main Dec 12, 2022
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023

fix(preview): Revert "fix: check if build exists so preview doesn't show 404s due to nonexistent build (vitejs#10564)"

This reverts commit 0a1db8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants