Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ?inline warning for .css.js file #11347

merged 1 commit into from
Dec 12, 2022


Copy link

Fixes #11328


See #11328

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link
Member Author

Merging this one so we can get in the next patch as it is affecting vanilla-extract users. @sapphi-red please check this PR afterward, I reviewed that warning for .css files is still generated. What is more, the css playground has tons of these now deprecated imports.

@patak-dev patak-dev added the p4-important Violate documented behavior or significantly improves performance (priority) label Dec 12, 2022
@patak-dev patak-dev merged commit 729fb1a into main Dec 12, 2022
@patak-dev patak-dev deleted the fix/false-positive-warning-for-css branch December 12, 2022 19:12
Copy link

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p4-important Violate documented behavior or significantly improves performance (priority)
None yet

Successfully merging this pull request may close these issues.

False positive of ?inline check for styles.css.ts file
2 participants