Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make vite optimize prebundle for dev #11387

merged 1 commit into from
Dec 17, 2022


Copy link


fixes #11005

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although a drastic change I think this shouldn't break things in practice and feels like a better default until we have better support for optimize in build + SSR, which we might need to extend the CLI further to support them.

@patak-dev patak-dev merged commit b4ced0f into vitejs:main Dec 17, 2022
@hershelh hershelh deleted the vite-optimize-in-dev branch December 17, 2022 13:01
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

vite optimize doesn't seem to actually be used with a subsequent vite
3 participants