fix: allow multiple bindCLIShortcuts calls with shortcut merging#21103
Merged
sapphi-red merged 7 commits intovitejs:mainfrom Nov 12, 2025
Merged
fix: allow multiple bindCLIShortcuts calls with shortcut merging#21103sapphi-red merged 7 commits intovitejs:mainfrom
bindCLIShortcuts calls with shortcut merging#21103sapphi-red merged 7 commits intovitejs:mainfrom
Conversation
sapphi-red
reviewed
Nov 11, 2025
Co-authored-by: 翠 <green@sapphi.red>
sapphi-red
reviewed
Nov 11, 2025
ArnaudBarre
approved these changes
Nov 11, 2025
| await vi.waitFor(() => expect(xUpdatedAction).toHaveBeenCalledOnce()) | ||
|
|
||
| // Ensure original xAction is not called again | ||
| expect(xAction).not.toBeCalled() |
Member
There was a problem hiding this comment.
It's probably a miss-understanding of the mocking system but I don't understand this assertion. Does using toHaveBeenCalledOnce above "reset" the counter? Otherwise I would have use toHaveBeenCalledOnce again
Contributor
Author
There was a problem hiding this comment.
I reset the counter with xAction.mockClear() right before calling bindCLIShortcuts again. If you find it confusing, happy to remove that and just assert whether xAction is still only called once.
Member
There was a problem hiding this comment.
Oh I missed that line. Ok makes more sense thanks. I think it just taste then so no need to change
Contributor
Author
|
Thanks for the review, @sapphi-red and @ArnaudBarre 🙌🏼 |
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 20, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.4 | ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 21, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.4 | ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 22, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.4 | ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 23, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.4 | ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 24, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.4 | ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 25, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.4 | ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 26, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.4 | ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 28, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.4 | ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 29, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.4 | ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Nov 30, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.4 | ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 1, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.6 | ## [v7.2.6](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-726-2025-12-01-small) #### <small>[7.2.6](vitejs/vite@v7.2.5...v7.2.6) (2025-12-01)</small> ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 2, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.6 | ## [v7.2.6](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-726-2025-12-01-small) #### <small>[7.2.6](vitejs/vite@v7.2.5...v7.2.6) (2025-12-01)</small> ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 4, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.6 | ## [v7.2.6](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-726-2025-12-01-small) #### <small>[7.2.6](vitejs/vite@v7.2.5...v7.2.6) (2025-12-01)</small> ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 4, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.6 | ## [v7.2.6](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-726-2025-12-01-small) #### <small>[7.2.6](vitejs/vite@v7.2.5...v7.2.6) (2025-12-01)</small> ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
Dec 5, 2025
| datasource | package | from | to | | ---------- | ------- | ----- | ----- | | npm | vite | 7.2.2 | 7.2.6 | ## [v7.2.6](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-726-2025-12-01-small) #### <small>[7.2.6](vitejs/vite@v7.2.5...v7.2.6) (2025-12-01)</small> ## [v7.2.4](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-724-2025-11-20-small) ##### Bug Fixes - revert "perf(deps): replace debug with obug ([#21107](vitejs/vite#21107))" ([2d66b7b](vitejs/vite@2d66b7b)) ## [v7.2.3](https://github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small-723-2025-11-20-small) ##### Bug Fixes - allow multiple `bindCLIShortcuts` calls with shortcut merging ([#21103](vitejs/vite#21103)) ([5909efd](vitejs/vite@5909efd)) - **deps:** update all non-major dependencies ([#21096](vitejs/vite#21096)) ([6a34ac3](vitejs/vite@6a34ac3)) - **deps:** update all non-major dependencies ([#21128](vitejs/vite#21128)) ([4f8171e](vitejs/vite@4f8171e)) ##### Performance Improvements - **deps:** replace debug with obug ([#21107](vitejs/vite#21107)) ([acfe939](vitejs/vite@acfe939)) ##### Miscellaneous Chores - **deps:** update dependency [@rollup/plugin-commonjs](https://github.com/rollup/plugin-commonjs) to v29 ([#21099](vitejs/vite#21099)) ([02ceaec](vitejs/vite@02ceaec)) - **deps:** update rolldown-related dependencies ([#21095](vitejs/vite#21095)) ([39a0a15](vitejs/vite@39a0a15)) - **deps:** update rolldown-related dependencies ([#21127](vitejs/vite#21127)) ([5029720](vitejs/vite@5029720))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15781.
Closes #15881.
This fixes an issue where calling
bindCLIShortcuts()multiple times would create duplicate readline instances and lose custom shortcuts from previous calls. This is useful for plugins adding their own shortcuts while Vite CLI continues to print the help message.Now when you bind shortcuts multiple times, they are properly merged, with new custom shortcuts taking priority:
This works for both dev and preview server.