Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure that esbuild uses the same working directory as Vite #4001

merged 2 commits into from Jun 30, 2021


Copy link

@fwouts fwouts commented Jun 28, 2021


There are a few places where the assumption is made that Vite and esbuild have the same working directory, for example here:

// the paths in `meta.outputs` are relative to `process.cwd()`

This leads to unexpected behaviour when the process invoking Vite has called process.chdir(), as that assumption is no longer valid. This can lead to needsInterop() returning true incorrectly, as exhibited in the example of #4000 (comment).

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link to docs for reference

@patak-dev patak-dev added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Jun 30, 2021
@antfu antfu merged commit 19abafe into vitejs:main Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants