Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add type: "module" hint to cache directory #4063

merged 2 commits into from Jul 2, 2021


Copy link

@sodatea sodatea commented Jul 1, 2021


Not sure it's a fix or feat. But adding this hint allows Node.js to correctly load modules inside the node_modules/.vite directory.

Removes the necessity of the following workaround in vite-jest:

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

antfu commented Jul 1, 2021

A bit hacky but interesting solution :)

Have you tested with custom cache dir that outside of node_modules? 🤔

Copy link
Member Author

sodatea commented Jul 1, 2021

Technically it's not a hack because Node.js has clearly documented how it determines the module type of a .js file:

I also opened #4064 as a more explicit approach.

Copy link

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this approach. Also, seems there are failing tests with the explicit .mjs

@antfu antfu merged commit 58a29b2 into vitejs:main Jul 2, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Co-authored-by: Anthony Fu <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants