Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract config.base in importAnalysisBuild.ts #4096

Merged
merged 2 commits into from Jul 13, 2021
Merged

Conversation

@hex-ci
Copy link
Contributor

@hex-ci hex-ci commented Jul 3, 2021

Description

issues: #4038

Extract config.base in importAnalysisBuild.ts to the preloadCode function.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
Extract config.base in importAnalysisBuild.ts to the preloadCode function.
@patak-js patak-js merged commit ab59598 into vitejs:main Jul 13, 2021
6 checks passed
6 checks passed
@github-actions
Build&Test: node-12, ubuntu-latest
Details
@github-actions
Build&Test: node-14, ubuntu-latest
Details
@github-actions
Build&Test: node-16, ubuntu-latest
Details
@github-actions
Build&Test: node-14, macos-latest
Details
@github-actions
Build&Test: node-14, windows-latest
Details
@github-actions
Lint: node-14, ubuntu-latest
Details
@hex-ci hex-ci deleted the hex-ci:patch-1 branch Jul 13, 2021
@vwkd vwkd mentioned this pull request Aug 25, 2021
7 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants