Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve indent of built html file #4227

Merged
merged 1 commit into from Jul 14, 2021

Conversation

@gnehcwu
Copy link
Contributor

@gnehcwu gnehcwu commented Jul 12, 2021

Description

Improve the indent in final built html file.

Additional context

Not sure if it is too picky or not, when build a project, injecting processed links/scripts into head with proper indent looks slightly better.

Before:
image

After:
image


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
@Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jul 13, 2021

Could you show a screenshot of the html code, preferably a before vs after? 🙂

@gnehcwu
Copy link
Contributor Author

@gnehcwu gnehcwu commented Jul 13, 2021

Updated the PR description with screenshots for a comparison, please kindly check @Shinigami92

@patak-js patak-js merged commit 0316f14 into vitejs:main Jul 14, 2021
6 checks passed
6 checks passed
@github-actions
Build&Test: node-12, ubuntu-latest
Details
@github-actions
Build&Test: node-14, ubuntu-latest
Details
@github-actions
Build&Test: node-16, ubuntu-latest
Details
@github-actions
Build&Test: node-14, macos-latest
Details
@github-actions
Build&Test: node-14, windows-latest
Details
@github-actions
Lint: node-14, ubuntu-latest
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants