Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(util): copyDir may cause an infinite loop #4310

Merged
merged 1 commit into from Jul 19, 2021
Merged

Conversation

@ygj6
Copy link
Collaborator

@ygj6 ygj6 commented Jul 19, 2021

Description

fix issue #4276

Additional context

When publicDir is set to './', that is, copyDir from './' to './dist'. This will cause the recursive call infinite loop,
and will create an unlimited number of ./dist/dist/dist/... folders.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
@antfu
antfu approved these changes Jul 19, 2021
@Shinigami92 Shinigami92 linked an issue that may be closed by this pull request Jul 19, 2021
6 tasks done
@patak-js patak-js merged commit da64197 into vitejs:main Jul 19, 2021
6 checks passed
6 checks passed
@github-actions
Build&Test: node-12, ubuntu-latest
Details
@github-actions
Build&Test: node-14, ubuntu-latest
Details
@github-actions
Build&Test: node-16, ubuntu-latest
Details
@github-actions
Build&Test: node-14, macos-latest
Details
@github-actions
Build&Test: node-14, windows-latest
Details
@github-actions
Lint: node-14, ubuntu-latest
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants