/ vite Public
fix: should load
--config foo.mjs as an ES module
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
This PR fixes the following bug:
When a user names their config file as
vitedirectly can correctly load the file as an ES module, but
vite --config vite.config.mjswould try to transpile that file to CJS first.
This bug was first mentioned at #4455 (comment)
I didn't find any existing tests for config file loading, so I didn't add one for this issue either.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following