Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should load --config foo.mjs as an ES module #5091

merged 1 commit into from Sep 26, 2021


Copy link

@sodatea sodatea commented Sep 26, 2021


This PR fixes the following bug:
When a user names their config file as vite.config.mjs, running vite directly can correctly load the file as an ES module, but vite --config vite.config.mjs would try to transpile that file to CJS first.

This bug was first mentioned at #4455 (comment)

Additional context

I didn't find any existing tests for config file loading, so I didn't add one for this issue either.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 5d2c50a into vitejs:main Sep 26, 2021
7 checks passed
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants