Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use the same target for optimized dependencies and source files #5095

Merged
merged 1 commit into from Sep 26, 2021

Conversation

sodatea
Copy link
Member

@sodatea sodatea commented Sep 26, 2021

fixes #4897

Description

It's the same as in

target: target || undefined,

As the default target is modules, optimizing dependencies no longer introduces the unicode export syntax, therefore the bug can be circumvented.

Additional context

I would love to add tests but I haven't figured out how to set up a minimal reproduction in vite 馃槀


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 8456a6f into vitejs:main Sep 26, 2021
7 checks passed
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@bluwy bluwy mentioned this pull request Jun 19, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in dev mode only (works in prod) with json import
2 participants