Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't overwrite default options unless given new value #5111

merged 1 commit into from Sep 27, 2021


Copy link


If you set a single option in commonjsOptions or dynamicImportVarsOptions then the defaults for those options (e.g. commonjsOptions: { include: [/node_modules/], extensions: ['.js', '.cjs']} will get overridden on line 259. I'm guessing that's not intended or else lines 240 & 245 could simply be removed

Additional context

I was investigating an issue that turned out to be an issue in @rollup/plugin-commonjs and was reading the code here when I stumbled across this

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 4d72b40 into vitejs:main Sep 27, 2021
7 checks passed
@benmccann benmccann deleted the commonjs branch September 27, 2021 18:32
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants