Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly handle postfix for getRealPath #5149

merged 1 commit into from Sep 30, 2021


Copy link


#4708 introduced a regression in 2.6, getRealPath was being called to resolve file+postfix, instead of only the file. This PR moves that call when resolving the file (it also refactor the function to avoid calling normalizePath twice)

Fixes #5053, #5146, #5148

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added the p4-important Violate documented behavior or significantly improves performance (priority) label Sep 30, 2021
Copy link
Member Author

@tjk @logaretm I think this should solve the reported regression, thanks for your help here

@patak-dev patak-dev merged commit 7d257c3 into main Sep 30, 2021
7 checks passed
@patak-dev patak-dev deleted the fix/url-suffix branch September 30, 2021 15:26
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Copy link

From vite 2.6.2 - vite + vue + tailwindcss don't working exacly.
Detail :
i turn on jit in vite + vue + tailwindcss
tailwindcss class don't update when hotreload.
i had set TAILWIND_MODE=watch when run dev project

Please check this issue

Copy link
Member Author

@nvthuong1996 please create an issue with a proper minimal reproduction linking to this PR so we can track the bug you are experiencing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p4-important Violate documented behavior or significantly improves performance (priority)
None yet

Successfully merging this pull request may close these issues.

JS worker import as URL broken with Vite 2.6.0-beta
4 participants