Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): read property of undefined #5177

merged 1 commit into from Oct 2, 2021

fix(dev): read property of undefined #5177

merged 1 commit into from Oct 2, 2021


Copy link

@tmkx tmkx commented Oct 2, 2021


const address = server.address()
const isAddressInfo = (x: any): x is AddressInfo => x.address
if (isAddressInfo(address)) {

const address: string | AddressInfo | null

isAddressInfo read .address property without checking.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tmkx was this change triggered by a case where 2.6.2 is not properly reporting the address info in the console?

Copy link
Contributor Author

tmkx commented Oct 2, 2021

Nope, it only occurs when I link Vite to another workspace, installing from npm works fine.
It's not caused by 2.6.2, I found it in the 2.6.0-beta commit.

@Shinigami92 Shinigami92 added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Oct 2, 2021
@patak-dev patak-dev merged commit 70e882f into vitejs:main Oct 2, 2021
7 checks passed
@tmkx tmkx deleted the fix/read-undefined branch October 2, 2021 15:58
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants