Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: strip NULL_BYTE_PLACEHOLDER before transform #6390

Merged
merged 2 commits into from Jan 5, 2022
Merged

fix: strip NULL_BYTE_PLACEHOLDER before transform #6390

merged 2 commits into from Jan 5, 2022

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Jan 5, 2022 •
edited

Description

fix: #6346

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ygj6 ygj6 added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jan 5, 2022
@ygj6 ygj6 marked this pull request as ready for review January 5, 2022 08:26
@patak-dev patak-dev merged commit 5964949 into vitejs:main Jan 5, 2022
@sapphi-red sapphi-red mentioned this pull request Jul 14, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot import virtual module from other virtual module loaded using ssrLoadModule
2 participants
@ygj6 @patak-dev