Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): do not clean id when passing to postcss (fix #7822) #7827



Copy link


This change was introduced as a part of #7173. I was struggling with css sourcemaps and supposed that this change was necessary at that time. But now I checked it works without this change.
Because it changes behaviors downstreams (as described in #7822), I think it is better to revert this part.

fix #7822

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy approved these changes Apr 20, 2022
Copy link

Friendly poke to merge 🙇

@patak-dev patak-dev merged commit 72f17f8 into vitejs:main May 4, 2022
8 checks passed
@sapphi-red sapphi-red deleted the fix/do-not-clean-id-when-passing-to-postcss branch May 4, 2022 09:00
Copy link

Thanks again @sapphi-red for jumping on a fix and @bluwy and @patak-dev for the timely review 🦚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

from id is always cleaned before being passed to the PostCSS plugins
4 participants