fix(css): do not clean id when passing to postcss (fix #7822) #7827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
approved these changes
Apr 20, 2022
MadLittleMods
reviewed
Apr 20, 2022
7 tasks
|
Friendly poke to merge |
patak-dev
approved these changes
May 4, 2022
9 tasks
|
Thanks again @sapphi-red for jumping on a fix and @bluwy and @patak-dev for the timely review |
MadLittleMods
added a commit
to vector-im/hydrogen-web
that referenced
this pull request
May 5, 2022
Fix #722 Updating Vite to includes fixes from vitejs/vite#7822 -> vitejs/vite#7827
innocenzi
pushed a commit
to innocenzi/vite
that referenced
this pull request
May 18, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
This change was introduced as a part of #7173. I was struggling with css sourcemaps and supposed that this change was necessary at that time. But now I checked it works without this change.
Because it changes behaviors downstreams (as described in #7822), I think it is better to revert this part.
fix #7822
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).