Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only handle merge ssr.noExternal #8003

merged 1 commit into from May 3, 2022


Copy link

@bluwy bluwy commented May 3, 2022


Previously noExternal in any level of the config would have special true handling. Now this is only handled for ssr.noExternal.

Additional context

Found this while discussing the potential use of mergeConfig in vite-plugin-svelte

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label May 3, 2022
@patak-dev patak-dev merged commit 642d65b into vitejs:main May 3, 2022
10 checks passed
@bluwy bluwy deleted the merge-ssr-external branch May 3, 2022 18:52
innocenzi pushed a commit to innocenzi/vite that referenced this pull request May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants