Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): allow ssrTransform to parse hashbang #8005

merged 3 commits into from May 4, 2022


Copy link


fix #8002

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy approved these changes May 3, 2022
Copy link

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad. Looks like the tests are failing. I think it's related to the snapshots whitespace updates in the diff. Source changes looks good though.

@bluwy bluwy added p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) feat: ssr labels May 3, 2022
ydcjeff approved these changes May 4, 2022
bluwy approved these changes May 4, 2022
@patak-dev patak-dev merged commit 6420ba0 into vitejs:main May 4, 2022
10 checks passed
innocenzi pushed a commit to innocenzi/vite that referenced this pull request May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
feat: ssr p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
None yet

Successfully merging this pull request may close these issues.

Enable to parse shebang in the function ssrTransform
4 participants