Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): hoist external @import for non-split css #8022



Copy link


fixes #5323

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) label May 6, 2022
@patak-dev patak-dev merged commit 5280908 into vitejs:main May 6, 2022
Copy link

Is this fixing a regression in 2.9 or the problem was already present before? The fix looks straightforward enough to back port it to the v2 branch and include it in 2.9.x

Copy link
Member Author

This problem was already present at 2.6. I don't know when it started happening.

@sapphi-red sapphi-red deleted the fix/hoist-import-for-non-split-css branch May 6, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
feat: css p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
None yet

Successfully merging this pull request may close these issues.

Dynamic css imports + css @import statements result in spurious warnings
3 participants