Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: glob types #8257

merged 1 commit into from May 21, 2022

fix: glob types #8257

merged 1 commit into from May 21, 2022


Copy link

@poyoho poyoho commented May 21, 2022


fix: #8249

Additional context

importGlob.d reference by client.d.ts, after #7877. we need to add dom / webworker in tsconfig.json to determine env. I think we don't need to determine env of the Worker.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried testing this locally against SvelteKit using pnpm overrides. I wasn't getting this error so I'd so go ahead and merge this.

I was getting some different errors, but I can't say if that's because of the way I was testing or if there's still something else wrong. Maybe @bluwy or @dominikg would have some ideas. E.g. do we need to start a branch of vite-plugin-svelte with the Vite peerDep set to v3 for testing with SvelteKit?

@patak-dev patak-dev merged commit 03b227e into vitejs:main May 21, 2022
@poyoho poyoho deleted the chore/glob-types branch May 22, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

3.0.0-alpha.1: missing dependency / types for okie
3 participants