Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove empty chunk css imports when using esnext #8345

merged 2 commits into from Jun 1, 2022


Copy link


Fixes #8330

  • When building to esnext a single quote rather than double quote is used. Fixing the regex causes it to remove the empty chunk import statement correctly.

Additional context

This fixes a bug in Astro and Sveltekit (see sveltejs/kit#5052)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: css p3-downstream-blocker 🔨 Blocking the downstream ecosystem to work properly (priority) labels May 27, 2022
Co-authored-by: 翠 / green <>
@patak-dev patak-dev merged commit b3d9652 into vitejs:main Jun 1, 2022
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
feat: css p3-downstream-blocker 🔨 Blocking the downstream ecosystem to work properly (priority)
None yet

Successfully merging this pull request may close these issues.

Removal of empty chunks doesn't update all imports
3 participants