Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssr-manifest no base #8371

merged 5 commits into from May 28, 2022

fix: ssr-manifest no base #8371

merged 5 commits into from May 28, 2022


Copy link

@poyoho poyoho commented May 28, 2022


fix: #7682

Additional context

fix deps no add config.base

chunk.imports = chunk.imports.filter((file) => {
if (pureCssChunks.has(file)) {
const {
viteMetadata: { importedCss }
} = bundle[file] as OutputChunk
importedCss.forEach((file) =>
return false
return true

ssr-manifest will add base path for chunk.modules and no add base path for importedCss. And importCss is base on rollup chunk.imports it seems to base on outputPath, so I thin k it can add the base path.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label May 28, 2022
@patak-dev patak-dev merged commit 37eb5b3 into vitejs:main May 28, 2022
@poyoho poyoho deleted the fix/ssrManifest branch May 29, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
None yet
3 participants