Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new hook configurePreviewServer (#7658) #8437

merged 1 commit into from Jun 2, 2022


Copy link


I ran git cherry-pick 20ea9999765ea372c20acc39e05cd81b98c9f6fe to pull in #7658

Additional context

We'd like to replace the svelte-kit CLI with the vite CLI and mostly use vite.config.js instead of svelte.config.js. It's a really big change both for us and our users that dwarfs the rest of the 3.x upgrade. If we can add this new feature in 2.9 as well it would allow us to start migrating users and drop a lot of brittle code that we currently have to support both code paths until this feature is available

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 7b972bc into vitejs:v2 Jun 2, 2022
10 of 15 checks passed
@benmccann benmccann deleted the v2-configurePreviewServer branch June 2, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants