Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont handle sigterm in middleware mode #8550

merged 3 commits into from Jun 12, 2022


Copy link

@bluwy bluwy commented Jun 12, 2022


Fix #7627

Additional context

Not sure if this is considered breaking, but we made similar changes in the past in minors, e.g. #4232

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) label Jun 12, 2022
Copy link

About the breaking change bit, we could consider this a bug fix. Maybe we need an advanced section in the migration guide targeted at integration and framework maintainers so we can at least add a point about this change (like bug fixes that may require special attention)

Co-authored-by: patak <>
@patak-dev patak-dev merged commit c6f43dd into vitejs:main Jun 12, 2022
sapphi-red added a commit to sapphi-red/vite that referenced this pull request Jun 14, 2022
@bluwy bluwy deleted the fix-sigterm-middleware branch November 6, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
None yet

Successfully merging this pull request may close these issues.

When running in middleware mode, vite should not kill process on SIGTERM
2 participants