Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): only rewrite .js loader in loadConfigFromBundledFile #8556

merged 1 commit into from Jun 13, 2022


Copy link

@CHOYSEN CHOYSEN commented Jun 12, 2022


fixes #8555

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging Object.keys(_require.extensions) gives [ '.js', '.json', '.node' ]. Looks like .js is shared for .mjs and .cjs too.

@bluwy bluwy added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Jun 13, 2022
@patak-dev patak-dev merged commit 2548dd3 into vitejs:main Jun 13, 2022
@CHOYSEN CHOYSEN deleted the fix/cjs-config branch June 13, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

can not use .cjs config file
4 participants