Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable inlineDynamicImports for = node #8641



Copy link

@sapphi-red sapphi-red commented Jun 17, 2022


inlineDynamicImports was enabled for both = 'node' and = 'webworker'.

AFAIK there's no reason to force the output to be a single file when is node and inlineDynamicImports option has a caveat.
So I think we should not enable inlineDynamicImports for = 'node' by default.

WIP: I need to check if it does not affect ssr manifest because this commit (107e79e) introduced this change. playground/ssr-vue seems to work.
WIP: add docs

fixes #7356
fixes #8571

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red force-pushed the feat/disable-inline-dynamic-imports-for-ssr branch from db85598 to 0002ff0 Compare June 19, 2022 13:21
@sapphi-red sapphi-red marked this pull request as ready for review June 19, 2022 13:21
@sapphi-red sapphi-red added this to the 3.0 milestone Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Archived in project

Successfully merging this pull request may close these issues.

ssr does not properly handle dynamic import correctly in onMounted Top Level Await of Modules with SSR
2 participants