Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): skip localhost verbatim dns lookup #8642

merged 2 commits into from Jun 17, 2022


Copy link

@bluwy bluwy commented Jun 17, 2022


Based on discussion in discord, we should dns.lookup with the default options so that other tools can lookup localhost equally too.

Additional context

@sapphi-red will update the docs in #8634

I'm not sure why the tests pass before.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy changed the title fix(server): lookup localhost without explicit verbatim fix(server): skip localhost verbatim dns lookup Jun 17, 2022
Copy link

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@patak-dev patak-dev merged commit 7632247 into vitejs:main Jun 17, 2022
@bluwy bluwy deleted the fix-remove-lookup-verbatim branch June 17, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants