Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm): support decoding data URL in Node < v16 (backport of #8622 for v2 branch) #8668

Merged
merged 1 commit into from Jun 20, 2022

Conversation

pastelmind
Copy link
Contributor

@pastelmind pastelmind commented Jun 19, 2022

Description

This is a backport of #8622 for the v2 branch, as requested by #8622 (comment). For details, please refer to #8622.

Additional context

(none)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Node < v16 do not provide a global `atob()` function for decoding base64
strings, and must use `Buffer.from()` instead. Furthermore,
`Buffer.from(str, 'base64').toString()` is much faster than `atob()` in
Node. Thus, prefer to use `Buffer.from()` if possible.
bluwy
bluwy approved these changes Jun 20, 2022
@patak-dev patak-dev merged commit 1afc1c2 into vitejs:v2 Jun 20, 2022
10 of 15 checks passed
@pastelmind pastelmind deleted the fix/wasm-node14-support-vite2 branch Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants