fix(plugin-react): set this-is-undefined-in-esm
to silent if classic runtime (fixes #8644)
#8674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description
For automatic runtime it was fixed upstream (evanw/esbuild@0905d85).
But for classic runtime it still happens (evanw/esbuild#2328 (comment)).
This PR sets
esbuild.logOverride['this-is-undefined-in-esm'] = 'silent'
automatically when classic runtime is used.This PR only works with esbuild 0.14.42+.
Vite 3.0.0-alpha.11+ requires 0.14.43 so it is safe.
vite/packages/vite/package.json
Line 60 in afe88ff
fixes #8644
Additional context
related: evanw/esbuild#2328
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).