Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export esbuildVersion and rollupVersion #8675

merged 2 commits into from Jun 20, 2022


Copy link


esbuild does not accept passing unknown options.
For example, #8674 does not work with 0.14.41 or below because logOverride does not exist.

By exporting this, plugins can use it to conditionally set esbuild options.
This will reduce peer dependency bumps.

AFAIK it could also be obtained by the code below, but it is complicated.

import { createRequire } from 'node:module'

const _require = createRequire(import.meta.url)
const vitePath = _require.resolve('vite')
const _viteRequire = createRequire(vitePath)
const { version: esbuildVersion } = _viteRequire('esbuild')

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) label Jun 20, 2022
patak-dev previously approved these changes Jun 20, 2022
Copy link

Maybe we should do the same with rollup?

Copy link
Member Author

Added rollup one too. 👍

@patak-dev patak-dev changed the title feat: export esbuild version feat: export esbuildVersion and rollupVersion Jun 20, 2022
@patak-dev patak-dev merged commit 15ebe1e into vitejs:main Jun 20, 2022
@sapphi-red sapphi-red deleted the feat/export-esbuild-version branch June 20, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants