Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SSR with relative base #8683

merged 2 commits into from Jun 20, 2022

fix: SSR with relative base #8683

merged 2 commits into from Jun 20, 2022


Copy link


We discussed with @danielroe, using his vote to merge this one so we can release an alpha.

During SSR with relative base, we were generating paths using import.meta.url. Relative base should be applied only for client code. This PR disables it in SSR so runtime and url from advanced base options will be used. And if the relative base shortcut is used, the global base fallbacks to /.

The API for experimental.buildAdvancedBaseOptions may need to be expanded to accommodate SSR. We would discuss this in other PRs and it isn't blocking the beta.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev merged commit c1667bb into main Jun 20, 2022
@patak-dev patak-dev deleted the fix/relative-base-in-ssr branch June 20, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant