Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable tree-shaking for lib es #8737

merged 1 commit into from Jun 23, 2022


Copy link


This PR enables treeShaking for lib es output. This will reduce output size.
minify removes pure annotations but treeShaking does not remove them.

before (esbuild repl)
--minify + --tree-shaking (esbuild repl)
this PR: --tree-shaking (esbuild repl)

close #8728

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) label Jun 23, 2022
Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 1471ef5
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

@patak-dev patak-dev merged commit 5dc0f72 into vitejs:main Jun 23, 2022
Copy link
Member Author

All of them does not use lib mode, so those are not related.
About #8713 and #8464, it seems to be related to the build time optimization.

@sapphi-red sapphi-red deleted the feat/tree-shake-lib-es branch June 23, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
feat: library mode p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
None yet

Successfully merging this pull request may close these issues.

CSS doesn't extract correctly in lib mode since 2.9.10
3 participants