Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(lib): improve helper inject regex #8741



Copy link


This PR improves perf of helper inject regex.
umd bench
iife bench

close #8738
close #8517
refs #7948
refs #8110

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 708ea77
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@patak-dev patak-dev merged commit 19fc7e5 into vitejs:main Jun 23, 2022
@sapphi-red sapphi-red deleted the perf/lib-improve-helper-inject-regex branch June 24, 2022 01:44
chrispcampbell added a commit to climateinteractive/SDEverywhere that referenced this pull request Jun 28, 2022
This avoids a performance regression that is reproducible when using vite 2.9.x versions >= 2.9.7.  It seems to have been fixed in 3.0.0 beta, see:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
2 participants