Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): __HMR_PORT__ should not be 'undefined' #8761

merged 1 commit into from Jun 24, 2022


Copy link

@sapphi-red sapphi-red commented Jun 24, 2022


When config.server.hmr exsits and both config.server.hmr.clientPort and config.server.hmr.port does not exist, __HMR_PORT__ was injected as 'undefined' instead of null.

For example a config like this:

export default {
  server: {
    hmr: {}

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: hmr p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) labels Jun 24, 2022
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 43d87b0
🔍 Latest deploy log

@patak-dev patak-dev merged commit 3271266 into vitejs:main Jun 24, 2022
@sapphi-red sapphi-red deleted the fix/hmr-port-undefined branch June 24, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
feat: hmr p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants