Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(worker): dont throw on import.meta.url in ssr #8846

merged 1 commit into from Jun 29, 2022


Copy link

@bluwy bluwy commented Jun 29, 2022


Fix #8839

Changes similar to #7219 but for workers. The reason for this change is also in the PR.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Jun 29, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 1b42f70
🔍 Latest deploy log

@patak-dev patak-dev merged commit ef749ed into vitejs:main Jun 29, 2022
@bluwy bluwy deleted the worker-import-meta-url-ssr branch June 30, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

"new URL(url, import.meta.url) is not supported in SSR" triggered even though the code never run on the server
2 participants