Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vue): limit passable compilerOptions #8994

merged 1 commit into from Jul 15, 2022


Copy link


Limited the type to only include meaningful options.

The following options might did have effect but AFAIK it does not make sense to set these:

  • These are deprecated and options.reactivityTransform handles it
    • options.script.refTransform
    • options.script.propsDestructureTransform
    • options.script.refSugar
  • These are handled by Vite internally
  • Vite handles preprocess for styles

The options except these and ones I left included did not have effect.

close #7832
close #7835

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: vue p1-chore 🧹 Doesn't change code behavior (priority) labels Jul 8, 2022
Copy link

netlify bot commented Jul 8, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 720b838
🔍 Latest deploy log

@patak-dev patak-dev requested a review from sodatea July 8, 2022 13:07
@patak-dev patak-dev merged commit b7b3e65 into vitejs:main Jul 15, 2022
@sapphi-red sapphi-red deleted the refactor/limit-compiler-options branch July 16, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p1-chore 🧹 Doesn't change code behavior (priority)
None yet

Successfully merging this pull request may close these issues.

Setting style.scoped to true / false in Vue options has no effect
3 participants