Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add react to optimizeDeps #9056

Merged
merged 1 commit into from Aug 19, 2022

Conversation

brillout
Copy link
Contributor

Description

If the user is using @vitejs/plugin-vue then we can assume that the user's app will most likely have vue has dependency.

Same for @vitejs/plugin-react.

Additional context

#9052 (comment)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit df45088
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62cdb79a07b51b00090e82b5

packages/plugin-vue/src/index.ts Outdated Show resolved Hide resolved
@brillout brillout force-pushed the fix/add-react-to-optimizeDeps branch from f17d14b to df45088 Compare July 12, 2022 18:04
@brillout brillout changed the title fix: add react and vue to optimizeDeps fix: add react to optimizeDeps Jul 12, 2022
@patak-dev
Copy link
Member

I think we should do this, but we may want to add it to the 3.1 milestone to get at least a week of testing without hitting stable.

@patak-dev patak-dev added the p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) label Jul 12, 2022
bluwy
bluwy approved these changes Jul 14, 2022
@patak-dev patak-dev added this to the 3.1 milestone Jul 14, 2022
@patak-dev patak-dev merged commit bc4a627 into vitejs:main Aug 19, 2022
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants