Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent production node_env in serve #9066

merged 1 commit into from Jul 13, 2022


Copy link

@bluwy bluwy commented Jul 13, 2022


Alternative to #9058
Fix #9057

Additional context

Make sure process.env.NODE_ENV is not production in dev. Some plugins may rely on this behaviour for hmr / improved perf for example, so we can't have production-like behaviours in dev.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Jul 13, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 25a791f
🔍 Latest deploy log

Copy link

Merging as @bluwy tested with vite-ecosystem-ci that this fix works for everyone.

@patak-dev patak-dev merged commit 7662998 into vitejs:main Jul 13, 2022
@bluwy bluwy deleted the fix-force-dev-env-in-serve branch July 13, 2022 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Vite 3 - isProduction flipped to true in dev server after a production build
2 participants