/ vite Public

# fix: resolve drive relative path#9097

Merged
merged 2 commits into from Jul 14, 2022
Merged

# fix: resolve drive relative path #9097

merged 2 commits into from Jul 14, 2022

## Conversation

This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

### Description

#8808 completely removed drive-relative path resolution behavior.
I removed this because I thought it was not intended: it was resolving using process.cwd() as a base, not the importer.

But I found that node.js supports drive-relative path resolution (nodejs/node#31710) and now I think this should be implemented.

This PR implements drive-relative path resolution (with the correct base). In addition, this PR adds absolute path resolution test.

I tested the behavior of drive-relative path by:
\$ node D:\foo.mjs on pwd = C:\

D:\foo.mjs

import '/bar.mjs'

console.log('foo.mjs')

D:\bar.js

console.log('bar.mjs')

### What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

### Before submitting the PR, please make sure you do the following

• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

added 2 commits Jul 14, 2022
 fix: resolve drive relative path 
 f7edb4f 
 test: resolve absolute path 
 841301d 
added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Jul 14, 2022

### ✅ Deploy Preview for vite-docs-main canceled.

🔨 Latest commit 841301d
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62cf7fe7994513000957fb34

### patak-dev commented Jul 14, 2022

 @dominikg is this related to the issue you mentioned, would you confirm that this fix works for you?

approved these changes

### dominikg commented Jul 14, 2022

 confirmed. Tested it in a local vm. Error happens with vite-3 from registry but not with a local build of this branch.

merged commit b393451 into vitejs:main Jul 14, 2022
15 checks passed
deleted the fix/resolve-drive-relative-path branch Jul 14, 2022