Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mention that Node.js 13/15 support is dropped (fixes #9113) #9116

Merged
merged 3 commits into from Jul 15, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 14, 2022

Description

Node.js 13 / 15 is already EOL and does not work with Vite 3. This was intended to drop but this was forgotten to mention.

fixes #9113

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p4-important Violate documented behavior or significantly improves performance (priority) label Jul 14, 2022
@netlify
Copy link

netlify bot commented Jul 14, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit b4f78c1
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62d0022d4f02cc000847c85c
😎 Deploy Preview https://deploy-preview-9116--vite-docs-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bluwy
bluwy approved these changes Jul 14, 2022
@liana-p
Copy link

liana-p commented Jul 14, 2022

Thanks for adding this 👍

@patak-dev patak-dev merged commit 2826303 into vitejs:main Jul 15, 2022
12 checks passed
@sapphi-red sapphi-red deleted the fix/remove-node15 branch Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[V3] Error on build in CI: Cannot find module 'node:path' in vite.config.ts
5 participants