Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): remove ssr.external config #9128

merged 2 commits into from Jul 15, 2022


Copy link


IIUC since Vite 3 externalizes everything by default, this is not needed. Also this prevents #9117 to work well. So I think this should be removed.

fixes #9117

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added plugin: vue p2-has-workaround 🍰 Bug, but has workaround (priority) labels Jul 15, 2022
Copy link

netlify bot commented Jul 15, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 6b78af4
🔍 Latest deploy log

ydcjeff previously approved these changes Jul 15, 2022
@patak-dev patak-dev merged commit ec91f98 into vitejs:main Jul 15, 2022
@sapphi-red sapphi-red deleted the fix/remove-vue-external branch July 16, 2022 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p2-has-workaround 🍰 Bug, but has workaround (priority)
None yet

Successfully merging this pull request may close these issues.

Vue is externalized no matter the ssr.noExternal value
3 participants