Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: externalize workspace relative import when bundle config #9140

Merged
merged 2 commits into from Jul 15, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jul 15, 2022

Description

Fixes failing sveltekit test in ecosystem-ci.

Additional context

The issue is that in this config file. It's importing ../../utils.js, which imports from another workspace package (kit). If we bundle the files and leave bare imports externalized, the bundled code can't import deps from that other workspace package, leading to a runtime error.

This PR makes sure that for files in another package, we should externalize them so that they can require the deps themselves. However, this may regress the second workaround for #5370 if the file from another package doesn't import anything, but I don't think that it's good to allow it in the first place (?).


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Jul 15, 2022
@netlify
Copy link

netlify bot commented Jul 15, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit 763a568
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-main/deploys/62d187b25cb0ce0008d43d35

@patak-dev patak-dev merged commit 5a8a3ab into main Jul 15, 2022
12 checks passed
@patak-dev patak-dev deleted the fix-config-import-out branch Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants