Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow declaring __dirname in config #9154

Merged
merged 1 commit into from Jul 16, 2022

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jul 16, 2022

Description

Currently __dirname/__filename cannot be declared at top level in config files since Vite injects those variables.
The code below is a common pattern but an error will happen.

import path from 'node:path'
import { defineConfig } from 'vite'

const __dirname = path.dirname(new URL(import.meta.url).pathname)

export default defineConfig({})

This PR makes it possible to declare those at top level.
esbuild's define only replaces top-level values (it's not a static replace) so this works.

refs #9147

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) label Jul 16, 2022
@sapphi-red sapphi-red changed the title feat: allow declaring dirname feat: allow declaring __dirname in config Jul 16, 2022
bluwy
bluwy approved these changes Jul 16, 2022
Copy link
Member

@bluwy bluwy left a comment

😲 The trick is right there all along.

@patak-dev patak-dev merged commit 1e078ad into vitejs:main Jul 16, 2022
13 checks passed
@sapphi-red sapphi-red deleted the feat/allow-declaring-dirname branch Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants