Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): build.ssr is set during dev, fix #9134 #9187

Merged
merged 1 commit into from Jul 18, 2022

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Jul 18, 2022

Description

We didn't detect this in vite-ecosystem-ci, as in all other projects but Qwik seems to only set build.ssr while building.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev patak-dev added p4-important Violate documented behavior or significantly improves performance (priority) feat: ssr labels Jul 18, 2022
bluwy
bluwy approved these changes Jul 18, 2022
@patak-dev patak-dev merged commit 99b0e67 into main Jul 18, 2022
17 of 18 checks passed
@patak-dev patak-dev deleted the fix/dev-ssr-when-build-ssr-is-harcoded branch Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants