Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ssrLoadModule executes code in non-strict mode, fixes #9197 #9199

Merged
merged 1 commit into from Jul 19, 2022

Conversation

patak-dev
Copy link
Member

@patak-dev patak-dev commented Jul 18, 2022

Description

Context:

Doing the PR with @Rich-Harris suggested change so we can run vite-ecosystem-ci to see if we can include this in the next patch. @brillout would you also review this one to check vite-plugin-ssr will be happy after this change?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@patak-dev
Copy link
Member Author

patak-dev commented Jul 18, 2022

vite-ecosystem-ci run for this PR: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/2692996595

@patak-dev patak-dev added p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) feat: ssr labels Jul 18, 2022
@patak-dev patak-dev changed the title fix: ssrLoadModule executes code in non-strict mode, fix #9197 fix: ssrLoadModule executes code in non-strict mode, fixes #9197 Jul 18, 2022
@patak-dev patak-dev linked an issue Jul 18, 2022 that may be closed by this pull request
7 tasks
bluwy
bluwy approved these changes Jul 19, 2022
@patak-dev patak-dev merged commit 5866cfb into main Jul 19, 2022
19 checks passed
@patak-dev patak-dev deleted the fix/ssr-in-strict-mode branch Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: ssr p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ssrLoadModule executes code in non-strict mode
3 participants